Do not use SHA-1 to look up D3D11 shaders #4393
Merged
+89
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
d3d11-no-sha1
branch
from
3150d37
to
0c000fd
Compare
Skips the expensive SHA-1 pass.
All D3D11 shader keys change, so we should invalidte existing caches.
doitsujin
force-pushed
the
d3d11-no-sha1
branch
from
0c000fd
to
2bcade9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves a few CPU cycles when creating shaders.
There's probably no good reason to change the hash algorithm for D3D9 since shaders there are tiny.